merlimat commented on a change in pull request #1850: Ship git info in jar and 
print at boot
URL: https://github.com/apache/incubator-pulsar/pull/1850#discussion_r191876620
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
 ##########
 @@ -308,6 +308,13 @@ public ServiceConfiguration getConfiguration() {
     public void start() throws PulsarServerException {
         mutex.lock();
 
+        LOG.info("Starting Pulsar Broker service; version: '{}'", ( 
brokerVersion != null ? brokerVersion : "unknown" )  );
+        LOG.info("Git Revision {}", 
PulsarBrokerVersionStringUtils.getGitSha());
+        LOG.info("Built by {} on {} at {}",
+                 PulsarBrokerVersionStringUtils.getBuildUser(),
+                 PulsarBrokerVersionStringUtils.getBuildHost(),
 
 Review comment:
   Sure, I was just concerned we might get an unfamiliar username if the person 
doing the release is not aware of this fact and has a username not relatable to 
apache id. Not a big deal anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to