mgodave commented on issue #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#issuecomment-393316639 I'm reworking it. Hopefully we won't need it. On Wed, May 30, 2018 at 2:54 PM, Boyang Jerry Peng <[email protected] > wrote: > *@jerrypeng* commented on this pull request. > ------------------------------ > > In pulsar-functions/instance/src/main/java/org/apache/pulsar/ > functions/source/PulsarSource.java > <https://github.com/apache/incubator-pulsar/pull/1845#discussion_r191919502> > : > > > @Slf4j > public class PulsarSource<T> implements Source<T> { > > private PulsarClient pulsarClient; > private PulsarSourceConfig pulsarSourceConfig; > - private Map<String, SerDe> topicToSerDeMap = new HashMap<>(); > + private Map<String, SerDe<T>> topicToSerDeMap = new HashMap<>(); > + > + private final Schema<T> emptySchema = new Schema<T>() { > > is there a way for us the avoid this? This can be confusing for the reader. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-pulsar/pull/1845#discussion_r191919502>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAh9Fk-C9jjEwjDyAasTsREPl0rUG9BDks5t3wb5gaJpZM4UOQKM> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
