merlimat commented on a change in pull request #1858: Cpp client: add
readCompacted in consumer config
URL: https://github.com/apache/incubator-pulsar/pull/1858#discussion_r192814326
##########
File path: pulsar-client-cpp/include/pulsar/ReaderConfiguration.h
##########
@@ -86,6 +86,9 @@ class ReaderConfiguration {
void setSubscriptionRolePrefix(const std::string& subscriptionRolePrefix);
const std::string& getSubscriptionRolePrefix() const;
+ ReaderConfiguration& setReadCompacted(bool compacted);
Review comment:
Even though there's a mix of styles in the current config objects, we should
try to keep the same return type for the same flag:
`void ConsumerConfiguration::setReadCompacted(bool compacted);`
vs
` ReaderConfiguration& ReaderConfiguration::setReadCompacted(bool
compacted);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
