This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new b2b97f2  Move UUID in S3 object name to start (#1888)
b2b97f2 is described below

commit b2b97f2a680a760fe54b8a5b66fc6018c68b01a1
Author: Ivan Kelly <[email protected]>
AuthorDate: Mon Jun 4 19:07:22 2018 +0200

    Move UUID in S3 object name to start (#1888)
    
    This acheives better load balancing on S3, as I guess internally
    objects in buckets are distributed over machines based on their
    names. Randomizing the names is the Amazon recommended way to acheive
    high request rates.
    
    
https://docs.aws.amazon.com/AmazonS3/latest/dev/request-rate-perf-considerations.html
    
    Master Issue: #1511
---
 .../org/apache/pulsar/broker/s3offload/S3ManagedLedgerOffloader.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOffloader.java
 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOffloader.java
index 73bb78a..f65eda9 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOffloader.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOffloader.java
@@ -116,11 +116,11 @@ public class S3ManagedLedgerOffloader implements 
LedgerOffloader {
     }
 
     static String dataBlockOffloadKey(long ledgerId, UUID uuid) {
-        return String.format("ledger-%d-%s", ledgerId, uuid.toString());
+        return String.format("%s-ledger-%d", uuid.toString(), ledgerId);
     }
 
     static String indexBlockOffloadKey(long ledgerId, UUID uuid) {
-        return String.format("ledger-%d-%s-index", ledgerId, uuid.toString());
+        return String.format("%s-ledger-%d-index", uuid.toString(), ledgerId);
     }
 
     // upload DataBlock to s3 using MultiPartUpload, and indexBlock in a new 
Block,

-- 
To stop receiving notification emails like this one, please contact
[email protected].

Reply via email to