rdhabalia commented on a change in pull request #1902: Support function
registration with package-url
URL: https://github.com/apache/incubator-pulsar/pull/1902#discussion_r192902717
##########
File path: pulsar-functions/proto/src/main/proto/Function.proto
##########
@@ -85,6 +85,7 @@ message SinkSpec {
message PackageLocationMetaData {
string packagePath = 1;
+ string packageUrl = 2;
Review comment:
I wanted to avoid deriving logic which can create issue if url and path has
conflicting convention in future. however, as @sijie mentioned if we want to
deprecate jar-submission then we can just keep one field. fixed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
