merlimat commented on a change in pull request #1908: adding protobuf schema
URL: https://github.com/apache/incubator-pulsar/pull/1908#discussion_r192959491
##########
File path: pulsar-client/pom.xml
##########
@@ -90,6 +90,12 @@
</exclusion>
</exclusions>
</dependency>
+
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
Review comment:
Client should depend on protobuf. If the object is indeed in protobuf, the
application should already have protobuf in the classpath. I believe the scope
for this dependency should be set to `provided`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
