ivankelly commented on a change in pull request #1871: Compaction documentation
follow-up
URL: https://github.com/apache/incubator-pulsar/pull/1871#discussion_r192995645
##########
File path: site/docs/latest/cookbooks/compaction.md
##########
@@ -11,13 +11,18 @@ To use compaction:
* You must manually [trigger](#trigger) compaction using the Pulsar
administrative API. This will both run a compaction operation *and* mark the
topic as a compacted topic.
* Your {% popover consumers %} must be [configured](#config) to read from
compacted topics ([Java consumers](#java), for example, have a `readCompacted`
setting that must be set to `true`). If this configuration is not set,
consumers will still be able to read from the non-compacted topic.
+{% include admonition.html type="warning" content="Compaction only works on
messages that have keys (as in the stock ticker example the stock symbol serves
as the key for each message). Keys can thus be thought of as the axis along
which compaction is applied. Messages that don't have keys are simply ignored
by compaction." %}
Review comment:
"simply ignored" can be confusing. Does it mean it just throws them away or
passes them through? (it passes them through).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
