jerrypeng commented on issue #1903: Support pulsar source to start consumer 
with topic patterns
URL: https://github.com/apache/incubator-pulsar/pull/1903#issuecomment-394896952
 
 
   @rdhabalia I think the PR looks good but as @srkukarni pointed out please 
also add this for python functions.  I think this change will break python 
functions since an additional cli argument i.e. topic pattern might be passed 
into python_instance_main.  Also please test to make sure that both java and 
python functions are able to be submitted and run properly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to