srkukarni closed pull request #1938: Have the ability to specify instance id
offset in localrun
URL: https://github.com/apache/incubator-pulsar/pull/1938
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
index 4b17ff5527..1031cbac97 100644
---
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
+++
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
@@ -663,9 +663,13 @@ protected FunctionDetails convert(FunctionConfig
functionConfig)
@Parameter(names = "--tls_trust_cert_path", description = "tls trust
cert file path")
protected String tlsTrustCertFilePath;
+ @Parameter(names = "--instanceIdOffset", description = "Start the
instanceIds from this offset")
+ protected Integer instanceIdOffset = 0;
+
@Override
void runCmd() throws Exception {
- CmdFunctions.startLocalRun(convertProto2(functionConfig),
functionConfig.getParallelism(), brokerServiceUrl,
+ CmdFunctions.startLocalRun(convertProto2(functionConfig),
functionConfig.getParallelism(),
+ instanceIdOffset, brokerServiceUrl,
AuthenticationConfig.builder().clientAuthenticationPlugin(clientAuthPlugin)
.clientAuthenticationParameters(clientAuthParams).useTls(useTls)
.tlsAllowInsecureConnection(tlsAllowInsecureConnection)
@@ -936,7 +940,7 @@ private void parseFullyQualifiedFunctionName(String fqfn,
FunctionConfig functio
}
protected static void
startLocalRun(org.apache.pulsar.functions.proto.Function.FunctionDetails
functionDetails,
- int parallelism, String brokerServiceUrl, AuthenticationConfig
authConfig,
+ int parallelism, int instanceIdOffset, String brokerServiceUrl,
AuthenticationConfig authConfig,
String userCodeFile, PulsarAdmin admin)
throws Exception {
@@ -956,7 +960,7 @@ protected static void
startLocalRun(org.apache.pulsar.functions.proto.Function.F
// TODO: correctly implement function version and id
instanceConfig.setFunctionVersion(UUID.randomUUID().toString());
instanceConfig.setFunctionId(UUID.randomUUID().toString());
- instanceConfig.setInstanceId(Integer.toString(i));
+ instanceConfig.setInstanceId(Integer.toString(i +
instanceIdOffset));
instanceConfig.setMaxBufferedTuples(1024);
instanceConfig.setPort(Utils.findAvailablePort());
RuntimeSpawner runtimeSpawner = new RuntimeSpawner(
diff --git
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
index 59b9201ae4..fa8ace468c 100644
---
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
+++
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
@@ -122,7 +122,7 @@ void processArguments() throws Exception {
@Override
void runCmd() throws Exception {
CmdFunctions.startLocalRun(createSinkConfigProto2(sinkConfig),
sinkConfig.getParallelism(),
- brokerServiceUrl,
+ 0, brokerServiceUrl,
AuthenticationConfig.builder().clientAuthenticationPlugin(clientAuthPlugin)
.clientAuthenticationParameters(clientAuthParams).useTls(useTls)
.tlsAllowInsecureConnection(tlsAllowInsecureConnection)
diff --git
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java
index a3bec4aa7a..c724b72f6c 100644
---
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java
+++
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java
@@ -118,7 +118,7 @@ void processArguments() throws Exception {
@Override
void runCmd() throws Exception {
CmdFunctions.startLocalRun(createSourceConfigProto2(sourceConfig),
sourceConfig.getParallelism(),
- brokerServiceUrl,
+ 0, brokerServiceUrl,
AuthenticationConfig.builder().clientAuthenticationPlugin(clientAuthPlugin)
.clientAuthenticationParameters(clientAuthParams).useTls(useTls)
.tlsAllowInsecureConnection(tlsAllowInsecureConnection)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
