massakam commented on a change in pull request #1921: Simplified authentication
wiht Python client lib
URL: https://github.com/apache/incubator-pulsar/pull/1921#discussion_r194611751
##########
File path: pulsar-client-cpp/python/src/authentication.cc
##########
@@ -18,14 +18,42 @@
*/
#include "utils.h"
+AuthenticationWrapper::AuthenticationWrapper() {}
+
AuthenticationWrapper::AuthenticationWrapper(const std::string& dynamicLibPath,
const std::string&
authParamsString) {
this->auth = AuthFactory::create(dynamicLibPath, authParamsString);
}
+struct AuthenticationTlsWrapper : public AuthenticationWrapper {
+ AuthenticationPtr auth;
Review comment:
Segmentation fault seems to occur unless deleting this. I think the same
applies to `AuthenticationAthenzWrapper`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
