merlimat opened a new pull request #1955: Workaround for ZK 3.4->3.5 upgrade URL: https://github.com/apache/incubator-pulsar/pull/1955 ### Motivation In current master code we have upgrade ZK version to 3.5, same version already used by BK to avoid all shading in internal components. A problem has been identified in upgrading from ZK 3.4.x to 3.5.x in that if a snapshot was not already created, a validation check in ZK 3.5 would prevent the ZK server to start. A fix is being discussed in https://issues.apache.org/jira/browse/ZOOKEEPER-3056. In the meantime, we need to apply a workaround. ### Modifications * Use AspectJ interceptor to modify ZK server constructor parameters and wrap `FileTxnSnapLog` class to catch and handle the precise `IOException` thrown by ZK 3.5 ### Result * We can update from ZK 3.4 to 3.5 without any manual fix required.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
