jerrypeng commented on a change in pull request #1956: Add function-package-url
support in function cli add url support to function cli
URL: https://github.com/apache/incubator-pulsar/pull/1956#discussion_r194958861
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java
##########
@@ -163,11 +171,10 @@ void runCmd() throws Exception {
protected String deserializationClassName;
@Parameter(names = "--parallelism", description = "The source's
parallelism factor (i.e. the number of source instances to run)")
protected Integer parallelism;
- @Parameter(
- names = "--jar",
- description = "Path to the jar file for the Source",
- listConverter = StringConverter.class)
+ @Parameter(names = "--jar", description = "Path to the jar file for
the Source. It also supports url-path (http/https/file) from which worker can
download the package.", listConverter = StringConverter.class)
protected String jarFile;
+ @Parameter(names = "--classNameArgType", description = "Sink impl
class's argument type if jar-file path is url")
Review comment:
Why do we need this for users to set? We can already resolve the types of
sink/source/functions from jars. Am I missing something here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
