ivankelly commented on a change in pull request #1995: [WIP] Migrate to test
containers Part 1
URL: https://github.com/apache/incubator-pulsar/pull/1995#discussion_r196703979
##########
File path:
tests/integration/src/test/java/org/apache/pulsar/tests/integration/PulsarStandAloneContainer.java
##########
@@ -0,0 +1,121 @@
+package org.apache.pulsar.tests.integration;
+
+import com.github.dockerjava.api.command.CreateContainerCmd;
+import com.github.dockerjava.api.command.LogContainerCmd;
+import com.github.dockerjava.api.model.Frame;
+import com.github.dockerjava.core.command.LogContainerResultCallback;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testcontainers.containers.GenericContainer;
+import org.testcontainers.containers.output.Slf4jLogConsumer;
+import org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy;
+
+import java.time.Duration;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.function.Consumer;
+
+import static java.time.temporal.ChronoUnit.SECONDS;
+
+public class PulsarStandAloneContainer extends
GenericContainer<PulsarStandAloneContainer> {
Review comment:
We shouldn't use standalone in integration tests as it doesn't represent the
software that runs on production clusters. Except of course to test that
standalone boots and runs, which we should be testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
