sijie commented on a change in pull request #2004: Issue 1943: remove
serializable from builders and add loadData to load configuration from a config
map
URL: https://github.com/apache/incubator-pulsar/pull/2004#discussion_r196988400
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/api/PulsarClient.java
##########
@@ -43,6 +46,17 @@ public static ClientBuilder builder() {
return new ClientBuilderImpl();
}
+ /**
+ * Create a pulsar client builder instance with a provided configuration
map.
+ *
+ * @param config configuration map.
+ * @return client builder
+ * @since 2.1.0
+ */
+ static ClientBuilder builder(Map<String, Object> config) {
Review comment:
That would be quite a few overloaded builders for consumer. Are you okay
with that?
- builder()
- builder(schema)
- builder(config)
- builder(schema, config)
if you are okay with that, I can go down into that route. then your
subsequent comment will be addressed as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
