[incubator-pulsar] branch master updated: Enable CRC32-C by default in BK client (#2002)

[mmerli]

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 8cc296e  Enable CRC32-C by default in BK client (#2002)
8cc296e is described below

commit 8cc296ea7f44811ea1b6a5a07c4217ea16349227
Author: Matteo Merli <mme...@apache.org>
AuthorDate: Thu Jun 21 00:14:42 2018 -0700

    Enable CRC32-C by default in BK client (#2002)
    
    * Enable CRC32-C by default in BK client
    
    * Added upgrade notes
---
 conf/broker.conf                                              |  6 +++---
 .../java/org/apache/pulsar/broker/ServiceConfiguration.java   |  6 +++---
 site/release-notes.md                                         | 11 +++++++++++
 3 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/conf/broker.conf b/conf/broker.conf
index 8abbf5b..c214840 100644
--- a/conf/broker.conf
+++ b/conf/broker.conf
@@ -298,9 +298,9 @@ managedLedgerDefaultWriteQuorum=2
 # Number of guaranteed copies (acks to wait before write is complete)
 managedLedgerDefaultAckQuorum=2
 
-# Default type of checksum to use when writing to BookKeeper. Default is 
"CRC32"
-# Other possible options are "CRC32C" (which is faster), "MAC" or "DUMMY" (no 
checksum).
-managedLedgerDigestType=CRC32
+# Default type of checksum to use when writing to BookKeeper. Default is 
"CRC32C"
+# Other possible options are "CRC32", "MAC" or "DUMMY" (no checksum).
+managedLedgerDigestType=CRC32C
 
 # Amount of memory to use for caching data payload in managed ledger. This 
memory
 # is allocated from JVM direct memory and it's shared across all the topics
diff --git 
a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
 
b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
index 212c5c4..4cbef9b 100644
--- 
a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
+++ 
b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
@@ -304,9 +304,9 @@ public class ServiceConfiguration implements 
PulsarConfiguration {
     @FieldContext(minValue = 1)
     private int managedLedgerDefaultAckQuorum = 1;
 
-    // Default type of checksum to use when writing to BookKeeper. Default is 
"CRC32"
-    // Other possible options are "CRC32C" (which is faster), "MAC" or "DUMMY" 
(no checksum).
-    private DigestType managedLedgerDigestType = DigestType.CRC32;
+    // Default type of checksum to use when writing to BookKeeper. Default is 
"CRC32C"
+    // Other possible options are "CRC32", "MAC" or "DUMMY" (no checksum).
+    private DigestType managedLedgerDigestType = DigestType.CRC32C;
 
     // Max number of bookies to use when creating a ledger
     @FieldContext(minValue = 1)
diff --git a/site/release-notes.md b/site/release-notes.md
index 48c6467..1fe2c68 100644
--- a/site/release-notes.md
+++ b/site/release-notes.md
@@ -26,6 +26,17 @@ layout: content
 
 ## Apache incubator
 
+<!--
+### 2.1.0-incubating &mdash; XXXX-XX-XX <a id="2.1.0-incubating"></a>
+
+Notes:
+
+ * [#2002](https://github.com/apache/incubator-pulsar/pull/2002) Updated
+  default checksum configured in BookKeeper client to CRC32-C. This will mean
+  that,  while it is possible to downgrade a Pulsar cluster from 2.1 to 2.0,
+  it will not be possible to downgrade from 2.1 to 1.22 release directly.
+-->
+
 ### 2.0.1-incubating &mdash; 2018-06-18 <a id="2.0.1-incubating"></a>
 
 This release fixes issues reported for 2.0.0-rc1-incubating.