sijie commented on issue #2004: Issue 1943: remove serializable from builders and add loadData to load configuration from a config map URL: https://github.com/apache/incubator-pulsar/pull/2004#issuecomment-399018095 > one option to detect spelling mistakes (or variable name changes) would be to throw exception if there is any unknown key in the configuration map I believe the json converting logic covers the name mismatch. am I missing anything there? > Another consideration is that, with this change, the variable names become effective part of the API so we should have a test to make sure all the current keys are supported, to avoid having some of them onadvertently removed later on. the unit test I wrote covers this purpose. the stuffs you are worrying is more about backward compatibility between versions, which I think it should be covered by the json coverter. if a field is removed or renamed, the map config would contain wrong variables names, which when it's loaded as POJO, exception would be thrown, no?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
