sijie commented on a change in pull request #1995: [WIP] Migrate to test
containers Part 5
URL: https://github.com/apache/incubator-pulsar/pull/1995#discussion_r197323695
##########
File path:
tests/integration/src/test/java/org/apache/pulsar/tests/integration/TestCompaction.java
##########
@@ -85,47 +81,45 @@ public void testPublishCompactAndConsumeCLI() throws
Exception {
Assert.assertEquals(m.getData(), "content1".getBytes());
}
- PulsarClusterUtils.runOnAnyBroker(docker, clusterName,
- PulsarClusterUtils.PULSAR,
"compact-topic",
- "-t", topic);
+ cluster.execInBroker(
+ PulsarClusterUtils.PULSAR, "compact-topic",
+ "-t", topic);
try (Consumer<byte[]> consumer = client.newConsumer().topic(topic)
- .readCompacted(true).subscriptionName("sub1").subscribe())
{
+ .readCompacted(true).subscriptionName("sub1").subscribe()) {
Message<byte[]> m = consumer.receive();
Assert.assertEquals(m.getKey(), "key0");
Assert.assertEquals(m.getData(), "content1".getBytes());
}
}
}
- @Test
+ @Test(dependsOnMethods = "testPublishCompactAndConsumeCLI")
Review comment:
shouldn't depend on other methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
