DanielFerreiraJorge commented on issue #1993: Helm charts for deployment on GKE
URL: https://github.com/apache/incubator-pulsar/pull/1993#issuecomment-399404997
 
 
   @cckellogg I could easily create a gke-values.yaml, but I think it would 
confuse people more than help. For instance, if I include that `nodeSelector: 
cloud.google.com/gke-nodepool: default-pool`, newcomers might think this is a 
necessary step to deploy on GKE, which is not. 
   
   The way the chart is after the changes, is completely generic and can be 
deployed with the values unaltered on any kube cluster. 
   
   Thoughts?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to