aahmed-se commented on issue #1995: [WIP] Migrate to test containers Part 5 URL: https://github.com/apache/incubator-pulsar/pull/1995#issuecomment-400037392 I will go ahead with a separate module for now I couldn't get the test to work alongside with another , we will do a phased migration there after. -Ali On Mon, Jun 25, 2018 at 1:40 PM Sijie Guo <[email protected]> wrote: > it's docker client version and some-other library mismatch, will get into > shading issues if we don't do all at once or create another integration > test module. > > I don't think there are version conflicts. If you checked bookkeeper tests > <https://github.com/apache/bookkeeper/blob/master/tests/integration-tests-topologies/pom.xml>, > where the BC tests are on arquillian and newly added table service related > tests are on testcontainers. both dependencies exist in a common module, > which it is used on either arquillian tests and test containers tests. > > as what Ivan mentioned, a lot of utils in current integration tests are > docker client based, it is not specific to any testing framework. they are > common enough, which you don't need to comment them out or remove them. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-pulsar/pull/1995#issuecomment-400035076>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AHo1fYWD8qzVVePbru0IaE1H5IfH5EtUks5uASB_gaJpZM4UuXRz> > . > -- -Ali
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
