jiazhai commented on a change in pull request #2025: Allow non-pesistent topics
to be retrieved along with persistent ones from the "GetTopicsOfNamespace"
method
URL: https://github.com/apache/incubator-pulsar/pull/2025#discussion_r197973026
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/PatternTopicsConsumerImplTest.java
##########
@@ -74,7 +74,8 @@ public void testPatternTopicsSubscribeWithBuilderFail()
throws Exception {
final String topicName1 = "persistent://my-property/my-ns/topic-1-" +
key;
final String topicName2 = "persistent://my-property/my-ns/topic-2-" +
key;
final String topicName3 = "persistent://my-property/my-ns/topic-3-" +
key;
- List<String> topicNames = Lists.newArrayList(topicName1, topicName2,
topicName3);
+ final String topicName4 =
"non-persistent://my-property/my-ns/topic-4-" + key;
Review comment:
seems some space alignment issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
