jai1 commented on a change in pull request #2028: Original principal
authorization for admin API
URL: https://github.com/apache/incubator-pulsar/pull/2028#discussion_r198422860
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
##########
@@ -151,7 +157,21 @@ protected void validateSuperUserAccess() {
log.debug("[{}] Check super user access: Authenticated: {} --
Role: {}", uri.getRequestUri(),
isClientAuthenticated(appId), appId);
}
- if (!config().getSuperUserRoles().contains(appId)) {
+ if (pulsar.getConfiguration().getProxyRoles().contains(appId)) {
+ String originalPrincipal = originalPrincipal();
+ boolean proxyAuthorized =
pulsar.getConfiguration().getSuperUserRoles().contains(appId);
+ boolean originalPrincipalAuthorized =
!StringUtils.isBlank(originalPrincipal)
+ &&
!pulsar.getConfiguration().getProxyRoles().contains(originalPrincipal)
+ &&
pulsar.getConfiguration().getSuperUserRoles().contains(originalPrincipal);
Review comment:
may be create a function for this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
