mgodave commented on issue #1303: RateLimiterTest is flaky URL: https://github.com/apache/incubator-pulsar/issues/1303#issuecomment-401569992 OK, just had to reacquaint myself with the issue. The problem is that the entire test relies on "beating" the inherent race conditions between threads: the scheduler thread and the test thread. Since the RateLimiter is just scheduling on the scheduler all we're really accomplishing is testing whether the ScheduledExecutorService is scheduling things at a fixed rate. I agree there should be a "sanity" check here that things open/close and that the basic functionality exists but there's not really much here. The RateLimiter talks about why it doesn't use Guava's but I think it might be worth re-evaluating, looking for a different implement library implementation, or paring things down dramatically.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
