aahmed-se commented on issue #2080: Extract out common code from standalone URL: https://github.com/apache/incubator-pulsar/pull/2080#issuecomment-402366099 I plan to add a builder that will make use of constructors and setters. On Tue, Jul 3, 2018 at 10:16 PM Boyang Jerry Peng <[email protected]> wrote: > *@jerrypeng* commented on this pull request. > ------------------------------ > > In pulsar-broker/src/main/java/org/apache/pulsar/StandalonePulsarBase.java > <https://github.com/apache/incubator-pulsar/pull/2080#discussion_r200010151> > : > > > + > +public abstract class StandalonePulsarBase { > + > + private static final Logger log = LoggerFactory.getLogger(StandalonePulsarBase.class); > + > + PulsarService broker; > + PulsarAdmin admin; > + LocalBookkeeperEnsemble bkEnsemble; > + ServiceConfiguration config; > + WorkerService fnWorkerService; > + > + public String getConfigFile() { > + return configFile; > + } > + > + public boolean isWipeData() { > > do you plan to override this getter methods in the embedded pulsar runner > implementation? > > — > You are receiving this because you were assigned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-pulsar/pull/2080#pullrequestreview-134239765>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AHo1fUnlyeiq_6VJRhX2W-dWoes8wULqks5uDE-0gaJpZM4VBlfS> > . > -- -Ali
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
