aahmed-se commented on a change in pull request #2078: Enhance Pulsar cluster
with container logs
URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r200235772
##########
File path:
tests/integration/semantics/src/test/java/org/apache/pulsar/tests/integration/functions/runtime/PulsarFunctionsRuntimeTest.java
##########
@@ -57,7 +58,7 @@ public PulsarFunctionsRuntimeTest(ContainerFactory
containerFactory) {
@Test(dataProvider = "FunctionRuntimes")
public void testExclamationFunction(Runtime runtime) throws Exception {
- if (ContainerFactory.THREAD == containerFactory && Runtime.PYTHON ==
runtime) {
+ if (functionProcessingMode == FunctionProcessingMode.THREAD && runtime
== Runtime.PYTHON) {
Review comment:
lvalue are suppose to be variables by convention
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
