merlimat commented on a change in pull request #2041: Added ReadOnlyCursor to
ManagedLedger
URL: https://github.com/apache/incubator-pulsar/pull/2041#discussion_r200456453
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
##########
@@ -255,6 +260,64 @@ public void initializeFailed(ManagedLedgerException e) {
});
}
+
+
+ @Override
+ public ReadOnlyCursor openReadOnlyCursor(String managedLedgerName,
Position startPosition, ManagedLedgerConfig config)
+ throws InterruptedException, ManagedLedgerException {
+ class Result {
Review comment:
All the sync methods in managed ledgers use this method of locally defined
classes. eg:
https://github.com/apache/incubator-pulsar/pull/2041/files/aa84a27696c8e79cafc4178aedf7c2f14c52d48e#diff-ffa235f2059c4ba4acc863fe75b1810cR181
This is just that the class is only a used in that method as a way to
collect a pair of results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
