srkukarni commented on a change in pull request #2128: Schedule task to update
function stats separately
URL: https://github.com/apache/incubator-pulsar/pull/2128#discussion_r201799408
##########
File path: pulsar-functions/proto/src/main/proto/InstanceCommunication.proto
##########
@@ -72,5 +72,7 @@ message HealthCheckResult {
service InstanceControl {
rpc GetFunctionStatus(google.protobuf.Empty) returns (FunctionStatus) {}
rpc GetAndResetMetrics(google.protobuf.Empty) returns (MetricsData) {}
+ rpc ResetMetrics(google.protobuf.Empty) returns (google.protobuf.Empty) {}
Review comment:
Get and Reset always go hand in hand. I believe thats the fundamental issue
with this pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
