sijie commented on a change in pull request #2101: Migrate compaction and s3 
offload test to testcontainers
URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202237886
 
 

 ##########
 File path: 
tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/topologies/PulsarCluster.java
 ##########
 @@ -136,52 +173,38 @@ public void start() throws Exception {
             "bin/init-cluster.sh");
         log.info("Successfully initialized the cluster.");
 
-        // create bookies
-        bookieContainers.putAll(
-            runNumContainers("bookie", spec.numBookies(), (name) -> new 
BKContainer(clusterName, name)
-                .withNetwork(network)
-                .withNetworkAliases(name)
-                .withEnv("zkServers", ZKContainer.NAME)
-                .withEnv("useHostNameAsBookieID", "true")
-                .withEnv("clusterName", clusterName)
-            )
-        );
+        // start bookies
+        bookieContainers.values().stream().forEach(BKContainer::start);
+        log.info("Successfully started {} bookie conntainers.", 
bookieContainers.values().size());
 
 Review comment:
   `bookieContainers.size()` should be good enough. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to