zhaijack commented on a change in pull request #2065: GCS offload support(2):
replace `s3client` api with `jclouds` related api
URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202505438
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/offload/impl/ManagedLedgerOffloader.java
##########
@@ -123,6 +191,10 @@ static String indexBlockOffloadKey(long ledgerId, UUID
uuid) {
return String.format("%s-ledger-%d-index", uuid.toString(), ledgerId);
}
+ public boolean createBucket() {
Review comment:
OK, will remove it. If needed, we could add it in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
