[incubator-pulsar] branch master updated: bin/bookkeeper doesn't output the result to the console (#2155)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 54dcee4   bin/bookkeeper doesn't output the result to the console 
(#2155)
54dcee4 is described below

commit 54dcee44101274dfb15d65817d3b1b549dec2768
Author: Sijie Guo <guosi...@gmail.com>
AuthorDate: Sat Jul 14 10:59:53 2018 -0700

     bin/bookkeeper doesn't output the result to the console (#2155)
    
    ### Motivation
    
    the change from log4j to log4j2 in 2.0 changes the logging behavior for 
`bin/bookkeeper`. some of the results of BookieShell is not showed up in 
Console, and other loggings (e.g. zookeeper) are showed up.
    
    ### Modifications
    
    - add a logger for `BookieShell` and set its log level to INFO and appender 
to Console.
    - make other loggers parameterized. and turn them off in `bin/bookkeeper`
    
    ### Result
    
    This achieves the same behavior as in 1.2x releases.
---
 bin/bookkeeper   |  6 ++++--
 conf/log4j2.yaml | 24 ++++++++++++++++++++++--
 2 files changed, 26 insertions(+), 4 deletions(-)

diff --git a/bin/bookkeeper b/bin/bookkeeper
index 80c2a9b..ef7793a 100755
--- a/bin/bookkeeper
+++ b/bin/bookkeeper
@@ -175,8 +175,10 @@ BOOKIE_LOG_FILE=${BOOKIE_LOG_FILE:-"bookkeeper-server.log"}
 
 #Configure log configuration system properties
 OPTS="$OPTS -Dpulsar.log.appender=$BOOKIE_LOG_APPENDER"
-OPTS="$OPTS -Dbookkeeper.log.dir=$BOOKIE_LOG_DIR"
-OPTS="$OPTS -Dbookkeeper.log.file=$BOOKIE_LOG_FILE"
+OPTS="$OPTS -Dbk.log.appender=$BOOKIE_LOG_APPENDER"
+OPTS="$OPTS -Dbk.log.level=error"
+OPTS="$OPTS -Dpulsar.log.dir=$BOOKIE_LOG_DIR"
+OPTS="$OPTS -Dpulsar.log.file=$BOOKIE_LOG_FILE"
 
 #Change to BK_HOME to support relative paths
 cd "$BK_HOME"
diff --git a/conf/log4j2.yaml b/conf/log4j2.yaml
index 2462ba6..ab2b9ab 100644
--- a/conf/log4j2.yaml
+++ b/conf/log4j2.yaml
@@ -37,6 +37,8 @@ Configuration:
         value: "Console"
       - name: "bk.log.level"
         value: "info"
+      - name: "bk.log.appender"
+        value: "BkRollingFile"
 
   # Example: logger-filter script
   Scripts:
@@ -165,17 +167,35 @@ Configuration:
           level: "${sys:pulsar.log.level}"
 
     Logger:
+      - name: org.apache.bookkeeper.bookie.BookieShell
+        level: info
+        additivity: false
+        AppenderRef:
+          - ref: Console
+
       - name: org.apache.bookkeeper
         level: "${sys:bk.log.level}"
         additivity: false
         AppenderRef:
-          - ref: BkRollingFile
+          - ref: "${sys:bk.log.appender}"
 
       - name: org.apache.distributedlog
         level: "${sys:bk.log.level}"
         additivity: false
         AppenderRef:
-          - ref: BkRollingFile
+          - ref: "${sys:bk.log.appender}"
+
+      - name: org.apache.zookeeper
+        level: "${sys:bk.log.level}"
+        additivity: false
+        AppenderRef:
+          - ref: "${sys:bk.log.appender}"
+
+      - name: verbose
+        level: info
+        additivity: false
+        AppenderRef:
+          - ref: Console
     
     # Logger to inject filter script
 #     - name: org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl