sijie commented on a change in pull request #2180: [WIP] Cleanup Arquillian 
consolidate projects
URL: https://github.com/apache/incubator-pulsar/pull/2180#discussion_r203152828
 
 

 ##########
 File path: tests/integration-tests-base/pom.xml
 ##########
 @@ -34,7 +34,7 @@
   <artifactId>integration-tests-base</artifactId>
   <packaging>pom</packaging>
 
-  <name>Apache Pulsar :: Tests :: Base module for Arquillian based integration 
tests</name>
+  <name>Apache Pulsar :: Tests :: Base module for TestContainers based 
integration tests</name>
 
 Review comment:
   if you combine all integration modules into one integration module, I would 
prefer calling it "Apache Pulsar :: Tests :: Integration Tests". there is no 
need to call out "testcontainers". just like we used testng for testing, but we 
don't call out testng in any module's name or description.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to