sijie commented on a change in pull request #2182: Issue 2110: get-retention
returns retentionSizeInMB as 0 when set to -1
URL: https://github.com/apache/incubator-pulsar/pull/2182#discussion_r203225243
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java
##########
@@ -342,7 +342,7 @@ void run() throws PulsarAdminException {
private String retentionTimeStr;
@Parameter(names = { "--size", "-s" }, description = "Retention size
limit (eg: 10M, 16G, 3T). "
- + "0 means no retention and -1 means infinite size retention",
required = true)
+ + "0 or less than 1MB means no retention and -1 means infinite
size retention", required = true)
Review comment:
because that is the current logic. the broker only takes MB as inputs. so if
you specify less than 1MB, it is 0. This change here is just to update the
documentation. we can discuss if we want to change this behavior, which will be
a bunch of BC considerations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
