sijie commented on issue #2180: [WIP] Cleanup Arquillian consolidate projects URL: https://github.com/apache/incubator-pulsar/pull/2180#issuecomment-406718933 >that's defeats of the purpose of the PR, h I don't think this defeats the purpose of the PR. I have seen a general problem with your PR is combining multiple things together. If this PR has broken into two pieces, one is removing arquilian dependency and modules, the other one is consolidating modules. the first piece could have been done. As a general advice for future PRs, I would recommend splitting any larger PR into smaller ones. that's easier to get things done and move forward faster. Otherwise a larger PR will end up in WIP for weeks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
