zhaijack commented on a change in pull request #2151: GCS offload support(3): add configs to support GCS driver URL: https://github.com/apache/incubator-pulsar/pull/2151#discussion_r204694519
########## File path: conf/broker.conf ########## @@ -507,6 +509,24 @@ s3ManagedLedgerOffloadMaxBlockSizeInBytes=67108864 # For Amazon S3 ledger offload, Read buffer size in bytes (1MB by default) s3ManagedLedgerOffloadReadBufferSizeInBytes=1048576 +# For Google Cloud Storage ledger offload region +# reference this page for more details: https://cloud.google.com/storage/docs/bucket-locations +gcsManagedLedgerOffloadRegion= + +# For Google Cloud Storage ledger offload, Bucket to place offloaded ledger into +gcsManagedLedgerOffloadBucket= + +# For Google Cloud Storage ledger offload, Max block size in bytes. (64MB by default, 5MB minimum) Review comment: Thanks, Yes, It is also 5 MB in GCS. https://cloud.google.com/storage/docs/json_api/v1/how-tos/multipart-upload Seems GCS make some alignment with aws s3 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
