massakam opened a new pull request #2226: Fix implementation of equals() for 
MessageId
URL: https://github.com/apache/incubator-pulsar/pull/2226
 
 
   ### Motivation
   
   When comparing MessageIdImpl and BatchMessageIdImpl using `equals()` method, 
the result may be incorrect. For example:
   
   ```java
   MessageIdImpl m1 = new MessageIdImpl(0, 0, 0);
   BatchMessageIdImpl m2 = new BatchMessageIdImpl(0, 0, 0, 1);
   System.out.println(m1.equals(m2));
   System.out.println(m2.equals(m1));
   ```
   
   ```
   true
   false
   ```
   ### Modifications
   
   Fixed the implementation of `equals()` method.
   
   ### Result
   
   MessageIdImpl and BatchMessageIdImpl will be compared correctly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to