sijie commented on a change in pull request #2227: Fix TestS3Offload
URL: https://github.com/apache/incubator-pulsar/pull/2227#discussion_r205202954
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/offload/impl/BlobStoreManagedLedgerOffloader.java
 ##########
 @@ -185,7 +185,6 @@ public static Credentials getCredentials(String driver, 
ServiceConfiguration con
             } catch (Exception e) {
                 // allowed, some mock s3 service not need credential
                 log.error("Exception when get credentials for s3 ", e);
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to