[incubator-pulsar] branch master updated: Fix TestS3Offload (#2227)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 9273c28  Fix TestS3Offload (#2227)
9273c28 is described below

commit 9273c282f4d29b16366262d1d8d96d875076792c
Author: Sijie Guo <guosi...@gmail.com>
AuthorDate: Wed Jul 25 14:13:38 2018 -0700

    Fix TestS3Offload (#2227)
    
    * Fix TestS3Offload
    
     ### Motivation
    
    s3 mock service doesn't need credential. so we will fail to load 
credentials on s3 integration tests.
    that is expected. However there is a regression when introducing GCS 
support in #2151:
    
https://github.com/apache/incubator-pulsar/pull/2151/files#diff-9160ffc9df7afcf42a8335f214393c6dR188
    
     ### Changes
    
    * Don't throw exception when failed to load aws credentials
    * change `log.error` to `log.warn`
---
 .../pulsar/broker/offload/impl/BlobStoreManagedLedgerOffloader.java    | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/offload/impl/BlobStoreManagedLedgerOffloader.java
 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/offload/impl/BlobStoreManagedLedgerOffloader.java
index 418c14f..fa0647c 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/offload/impl/BlobStoreManagedLedgerOffloader.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/offload/impl/BlobStoreManagedLedgerOffloader.java
@@ -184,8 +184,7 @@ public class BlobStoreManagedLedgerOffloader implements 
LedgerOffloader {
                 credentials = creds.getCredentials();
             } catch (Exception e) {
                 // allowed, some mock s3 service not need credential
-                log.error("Exception when get credentials for s3 ", e);
-                throw new PulsarServerException(e);
+                log.warn("Exception when get credentials for s3 ", e);
             }
 
             String id = "accesskey";