sijie commented on a change in pull request #2237: [website] Fix security page
links and includes
URL: https://github.com/apache/incubator-pulsar/pull/2237#discussion_r205310024
##########
File path: site2/website/scripts/replace.js
##########
@@ -49,7 +49,7 @@ const versions = getVersions();
const latestVersion = versions[0];
const from = [
- /pulsar:version/g,
+ /{{pulsar:version}}/g,
Review comment:
the main reason I changed to `{{}}` is because of this line:
https://github.com/apache/incubator-pulsar/pull/2237/files#diff-2e5bd7bb5ee452df3f4d1c90b6cfff0bL20
it is a bit confusing with `pulsar:pulsar:version`. I thought it is clear to
have `{{}}`. I changed `pulsar:version` in this PR for now. if we agreed that
is the direction we should head down, I can change the others to make things
consistent and clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
