cckellogg commented on a change in pull request #2237: [website] Fix security
page links and includes
URL: https://github.com/apache/incubator-pulsar/pull/2237#discussion_r205314170
##########
File path: site2/website/scripts/replace.js
##########
@@ -49,7 +49,7 @@ const versions = getVersions();
const latestVersion = versions[0];
const from = [
- /pulsar:version/g,
+ /{{pulsar:version}}/g,
Review comment:
{{}} are commonly used in templating engines so I was trying to avoid using
those for search and replace variables. I do see how it's confusing above.
Maybe we can do $pulsar:version or \<pulsar:version\> i'm not sure sure if
either of those are are any better, thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
