merlimat commented on a change in pull request #2254: Fix pulsar:version vars
in site2 docs.
URL: https://github.com/apache/incubator-pulsar/pull/2254#discussion_r205902157
##########
File path: site2/docs/deploy-bare-metal.md
##########
@@ -48,20 +48,20 @@ For machines running a bookie and a Pulsar broker, we
recommend using more power
To get started deploying a Pulsar cluster on bare metal, you'll need to
download a binary tarball release in one of the following ways:
* By clicking on the link directly below, which will automatically trigger a
download:
- * <a href="pulsar:binary_release_url" download>Pulsar pulsar:version binary
release</a>
+ * <a href="pulsar:binary_release_url" download>Pulsar {{pulsar:version}}
binary release</a>
* From the Pulsar [downloads page](pulsar:download_page_url)
* From the Pulsar [releases
page](https://github.com/apache/incubator-pulsar/releases/latest) on
[GitHub](https://github.com)
* Using [wget](https://www.gnu.org/software/wget):
```bash
-$ wget
http://archive.apache.org/dist/incubator/pulsar/pulsar-pulsar:version/apache-pulsar-pulsar:version-bin.tar.gz
+$ wget pulsar:binary_release_url
Review comment:
Sure, no problem with that. In any case, I think that the notation
`{{pulsar:version}}`, since it's common in many template languanges, would make
it clearer to someone editing this document that this will be somehow replaced
on the published version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
