rdhabalia commented on a change in pull request #2259: Fix: set
subscription-type based on message ordering
URL: https://github.com/apache/incubator-pulsar/pull/2259#discussion_r206274041
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -240,6 +240,8 @@ void processArguments() throws Exception {
protected FunctionConfig.ProcessingGuarantees processingGuarantees;
@Parameter(names = "--userConfig", description = "User-defined config
key/values")
protected String userConfigString;
+ @Parameter(names = "--retainOrdering", description = "Function
consumes and processes messages in order")
Review comment:
we have a function which requires to consume messages in order and it
requires FAILOVER subscription. we added this flag to maintain consistency with
sink where it already has [same
flag](https://github.com/apache/incubator-pulsar/blob/master/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java#L217)
to fulfill same requirement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
