srkukarni commented on a change in pull request #2266: Integrate functions and
io with schema registry
URL: https://github.com/apache/incubator-pulsar/pull/2266#discussion_r206325065
##########
File path:
pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfig.java
##########
@@ -71,18 +72,18 @@
@NotNull
@isImplementationOfClasses(implementsClasses = {Function.class,
java.util.function.Function.class})
private String className;
- @isListEntryCustom(entryValidatorClasses =
{ValidatorImpls.TopicNameValidator.class})
- private Collection<String> inputs;
- @isMapEntryCustom(keyValidatorClasses = {
ValidatorImpls.TopicNameValidator.class },
- valueValidatorClasses = { ValidatorImpls.SerdeValidator.class },
targetRuntime = ConfigValidation.Runtime.JAVA)
- @isMapEntryCustom(keyValidatorClasses = {
ValidatorImpls.TopicNameValidator.class }, targetRuntime =
ConfigValidation.Runtime.PYTHON)
- private Map<String, String> customSerdeInputs;
- @isValidTopicName
- private String topicsPattern;
+
Review comment:
the whole idea of functionconfig is to be user facing config. For simple
things like writing a function taking one input, users should be simply able to
say
inputs : topic
as opposed to the new way.
IMO we should support the inputs the way they are.
Inside we could translate inputs into a more comprehensive topicsSchema
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
