rdhabalia commented on issue #2259: Fix: set subscription-type based on message ordering URL: https://github.com/apache/incubator-pulsar/pull/2259#issuecomment-409360529 > looks like --subscription-type to allow people override the subscription for at-least-once and at-most-once processes is a better approach. in #2200 [first commit](https://github.com/apache/incubator-pulsar/pull/2200/commits/6757851bf86b1b8daa0137463ecbf44875075af8) had change to add `--subscription-type` but based on feedback we have added flag for `retain ordering`. > For functions, sources, and sinks, if the processing guarantee is set to effectively once, it is implied that order should be maintained and the subscription type to be failover. Isn't this PR address the same thing. if `guarantee is set to effectively once` then sub type will be set as FAILOVER else sub-type will be configured as per ordering-flag. is there anything we are missing here?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
