merlimat commented on a change in pull request #2219: Cpp client: add
PatternMultiTopicsConsumerImpl to support regex subscribe
URL: https://github.com/apache/incubator-pulsar/pull/2219#discussion_r207016724
##########
File path: pulsar-client-cpp/include/pulsar/Client.h
##########
@@ -108,6 +111,19 @@ class Client {
void subscribeAsync(const std::vector<std::string>& topics, const
std::string& subscriptionName,
const ConsumerConfiguration& conf, SubscribeCallback
callback);
+ /**
+ * subscribe for multiple topics, which match given regexPattern, under
the same namespace.
+ */
+ Result subscribe(const std::string& regexPattern, const std::string&
consumerName, Consumer& consumer,
Review comment:
Instead of using boolean parameter, we could change the method signature
into `subscribeWithRegex()` or similar, to make it more explicit in the
application code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
