sijie commented on a change in pull request #2266: Integrate functions and io
with schema registry
URL: https://github.com/apache/incubator-pulsar/pull/2266#discussion_r207384890
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -222,18 +224,27 @@ void processArguments() throws Exception {
description = "Path to the main Python file for the function
(if the function is written in Python)",
listConverter = StringConverter.class)
protected String pyFile;
- @Parameter(names = "--inputs", description = "The function's input
topic or topics (multiple topics can be specified as a comma-separated list)")
+ @Parameter(names = { "-i",
+ "--inputs" }, description = "The function's input topic or
topics (multiple topics can be specified as a comma-separated list)")
protected String inputs;
@Parameter(names = "--topicsPattern", description = "TopicsPattern to
consume from list of topics under a namespace that match the pattern. [--input]
and [--topicsPattern] are mutually exclusive. Add SerDe class name for a
pattern in --customSerdeInputs (supported for java fun only)")
protected String topicsPattern;
- @Parameter(names = "--output", description = "The function's output
topic")
+
+ @Parameter(names = {"-o", "--output"}, description = "The function's
output topic")
protected String output;
@Parameter(names = "--logTopic", description = "The topic to which the
function's logs are produced")
protected String logTopic;
- @Parameter(names = "--customSerdeInputs", description = "The map of
input topics to SerDe class names (as a JSON string)")
+
+ @Parameter(names = "--customSerdeInputs", description = "The map of
input topics to SerDe class names (as a JSON string)", hidden = true)
protected String customSerdeInputString;
- @Parameter(names = "--outputSerdeClassName", description = "The SerDe
class to be used for messages output by the function")
+
+ @Deprecated
+ @Parameter(names = "--outputSerdeClassName", description = "The SerDe
class to be used for messages output by the function", hidden = true)
protected String outputSerdeClassName;
+
+ @Parameter(names = {"-st", "--schemaType"}, description = "The builtin
schema type or custom schema class name to be used for messages output by the
function")
Review comment:
let's standardize the command line parameters to lower cases "--schema-type"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
