srkukarni commented on a change in pull request #2296: REST and CLI to get
function metrics in json for monitoring
URL: https://github.com/apache/incubator-pulsar/pull/2296#discussion_r207617064
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Functions.java
##########
@@ -259,4 +260,11 @@
* @throws PulsarAdminException
*/
List<WorkerInfo> getCluster() throws PulsarAdminException;
+
+ /**
+ * Get function worker metrics
+ * @return
+ * @throws PulsarAdminException
+ */
+ Metrics getMetrics() throws PulsarAdminException;
Review comment:
I see a disconnect here. Most of other calls listed here are all function
specific that get routed appropriately to the right worker who then answers
with the right information.
On the other hand, this particular call is for getting the metrics housed by
a specific worker. Do we want a different place to house such calls?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
