rdhabalia commented on a change in pull request #2296: REST and CLI to get
function metrics in json for monitoring
URL: https://github.com/apache/incubator-pulsar/pull/2296#discussion_r207621604
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Functions.java
##########
@@ -259,4 +260,11 @@
* @throws PulsarAdminException
*/
List<WorkerInfo> getCluster() throws PulsarAdminException;
+
+ /**
+ * Get function worker metrics
+ * @return
+ * @throws PulsarAdminException
+ */
+ Metrics getMetrics() throws PulsarAdminException;
Review comment:
> On the other hand, this particular call is for getting the metrics housed
by a specific worker. Do we want a different place to house such calls?
hmm.. yes. right now, in broker we have separate resource
[BrokerStats](https://github.com/apache/incubator-pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokerStatsBase.java)
to serve broker-localhost stats, probably we can add resource: `WorkerStats`
for consistency and we can add worker-specific stats in the same resource as
needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
