sijie commented on a change in pull request #2261: Avoid creating output topic
on tenant namespace if output-topic not provided
URL: https://github.com/apache/incubator-pulsar/pull/2261#discussion_r207687865
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -468,9 +468,6 @@ private void inferMissingArguments(FunctionConfig
functionConfig) {
if (StringUtils.isEmpty(functionConfig.getNamespace())) {
inferMissingNamespace(functionConfig);
}
- if (StringUtils.isEmpty(functionConfig.getOutput())) {
Review comment:
@rdhabalia I think the agreement here is not to create an output topic
implicitly. so why not fail submission if output is not specified and the
return type is not `void`? to me, fail fast is better than than using a
`DISABLED` sink. if people want to disable sink, there should be another flag
controlling that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
