merlimat commented on a change in pull request #2315: Enable TLS in client if
serviceUrl has pulsar+ssl:// or https://
URL: https://github.com/apache/incubator-pulsar/pull/2315#discussion_r207968654
##########
File path: pulsar-client-cpp/lib/ClientImpl.cc
##########
@@ -64,30 +64,42 @@ const std::string generateRandomName() {
}
typedef boost::unique_lock<boost::mutex> Lock;
+static const ClientConfiguration detectTls(const std::string& serviceUrl,
+ const ClientConfiguration&
clientConfiguration) {
+ ClientConfiguration conf(clientConfiguration);
+ std::string https("https");
+ std::string pulsarSsl("pulsar+ssl");
Review comment:
```cpp
static const std::string https("https");
static const std::string pulsarSsl("pulsar+ssl");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
