sijie commented on a change in pull request #2347: Fix: function with
multi-topic not acking on effectively-once
URL: https://github.com/apache/incubator-pulsar/pull/2347#discussion_r208791550
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarSource.java
##########
@@ -142,8 +140,18 @@ public void open(Map<String, Object> config,
SourceContext sourceContext) throws
.message(message)
.topicName(topicName)
.ackFunction(() -> {
- if (pulsarSourceConfig.getProcessingGuarantees() ==
FunctionConfig.ProcessingGuarantees.EFFECTIVELY_ONCE) {
- inputConsumer.acknowledgeCumulativeAsync(message);
+ if (pulsarSourceConfig
+ .getProcessingGuarantees() ==
FunctionConfig.ProcessingGuarantees.EFFECTIVELY_ONCE) {
+ // try to find actual consumer of the messageId
+ if (inputConsumer instanceof MultiTopicsConsumerImpl) {
Review comment:
does this mean ackCumulativeAsync is not working in
MultiTopicsConsumerImpl? If so, should this be fixed in
`MultiTopicsConsumerImpl` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
