ivankelly commented on a change in pull request #2351: Avoid double executor on 
non-persistent topic send operation
URL: https://github.com/apache/incubator-pulsar/pull/2351#discussion_r209090921
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java
 ##########
 @@ -188,44 +188,32 @@ public NonPersistentTopic(String topic, BrokerService 
brokerService) {
 
     @Override
     public void publishMessage(ByteBuf data, PublishContext callback) {
 
 Review comment:
   is this already running in the topic assigned executor?
   It would be good to be able to assert that things are running in the ordered 
executor thread we expect them to.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to